Skip to content

fix: add more clickhouse disallowed functions on config#31198

Merged
dpgaspar merged 2 commits intoapache:masterfrom
preset-io:chore/clickhous-allowed-functions
Dec 3, 2024
Merged

fix: add more clickhouse disallowed functions on config#31198
dpgaspar merged 2 commits intoapache:masterfrom
preset-io:chore/clickhous-allowed-functions

Conversation

@dpgaspar
Copy link
Copy Markdown
Member

@dpgaspar dpgaspar commented Nov 29, 2024

SUMMARY

Adding more Clickhouse functions to our disallowed config. Although these functions could and possibly should not be authorized by the database credentials set by an Superset admin, it's a plus for Superset to disallow them by default.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot Bot added the data:connect:clickhouse Related to Clickhouse label Nov 29, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.81%. Comparing base (76d897e) to head (a91d7e3).
⚠️ Report is 2419 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #31198       +/-   ##
===========================================
+ Coverage   60.48%   83.81%   +23.32%     
===========================================
  Files        1931      536     -1395     
  Lines       76236    38932    -37304     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32631    -13483     
+ Misses      28017     6301    -21716     
+ Partials     2105        0     -2105
Flag Coverage Δ
hive 48.79% <ø> (-0.37%) ⬇️
javascript ?
mysql 76.55% <ø> (?)
postgres 76.64% <ø> (?)
presto 53.29% <ø> (-0.52%) ⬇️
python 83.81% <ø> (+20.30%) ⬆️
sqlite 76.10% <ø> (?)
unit 60.87% <ø> (+3.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@michael-s-molina
Copy link
Copy Markdown
Member

michael-s-molina commented Nov 29, 2024

Thanks for the PR @dpgaspar. Could you add something to UPDATING.md?

@dpgaspar
Copy link
Copy Markdown
Member Author

dpgaspar commented Dec 2, 2024

Thanks for the PR @dpgaspar. Could you add something to UPDATING.md?

ok added

@dpgaspar dpgaspar merged commit 25f4226 into apache:master Dec 3, 2024
@dpgaspar dpgaspar deleted the chore/clickhous-allowed-functions branch December 3, 2024 10:48
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Mar 4, 2025
sadpandajoe pushed a commit that referenced this pull request Mar 4, 2025
@dpgaspar @sadpandajoe
fix: add more clickhouse disallowed functions on config (#31198)
dcaeb76 
(cherry picked from commit 25f4226)
@github-actions github-actions Bot added 🍒 4.1.2 Cherry-picked to 4.1.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 24, 2025
@mistercrunch mistercrunch added 🍒 4.1.3 Cherry-picked to 4.1.3 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

@villebro villebro Awaiting requested review from villebro

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels data:connect:clickhouse Related to Clickhouse size/XS v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.2 Cherry-picked to 4.1.2 🍒 4.1.3 Cherry-picked to 4.1.3 🍒 4.1.4 🚢 5.0.0 First shipped in 5.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dpgaspar @michael-s-molina @mistercrunch @sadpandajoe